feat: Allow duplicate output names in root ProjectNode#16500
Closed
mbasmanova wants to merge 1 commit intofacebookincubator:mainfrom
Closed
feat: Allow duplicate output names in root ProjectNode#16500mbasmanova wants to merge 1 commit intofacebookincubator:mainfrom
mbasmanova wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
|
@mbasmanova has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94146245. |
…ator#16500) Summary: Allow the root ProjectNode to have duplicate or empty output column names. This is needed to support SQL queries with duplicate column aliases such as `SELECT a AS x, b AS x`. The PlanConsistencyChecker now accepts the root node ID and skips output name validation for it. Differential Revision: D94146245
mbasmanova
force-pushed
the
export-D94146245
branch
from
7deff2c to
43ae5a5
Compare
amitkdutta
approved these changes
Feb 24, 2026
|
This pull request has been merged in b7319c1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Allow the root ProjectNode to have duplicate or empty output column names.
This is needed to support SQL queries with duplicate column aliases such as
SELECT a AS x, b AS x. The PlanConsistencyChecker now accepts the rootnode ID and skips output name validation for it.
Differential Revision: D94146245